- Mar 23, 2023
-
-
segfault authored
-
segfault authored
-
segfault authored
In these steps we check a condition and don't bring about a condition.
-
segfault authored
Check that all features are still enabled when activating the PersistentDirectory feature failed. Also improve the implementation of step "all tps features are active".
-
segfault authored
Use "tps feature" instead of "persistence preset".
-
segfault authored
-
segfault authored
-
segfault authored
-
segfault authored
In the Persistent Storage context, "active" means that a binding is currently active (e.g. bind mounted), "enabled" means that it's in the config file.
-
segfault authored
-
segfault authored
Show the "Your Persistent Storage is unlocked" message when the Persistent Storage was unlocked and some some features failed to activate.
-
segfault authored
-
segfault authored
-
segfault authored
-
segfault authored
-
segfault authored
-
segfault authored
-
segfault authored
-
segfault authored
In cases where the user did something unexpected which caused the failure, the output of the command can help the user to debug the issue themself.
-
segfault authored
-
segfault authored
It doesn't contain any useful information.
-
segfault authored
To ensure that the result of an Activate/Deactivate call is either the expected state or an error (which nudges users to send a bug report).
-
segfault authored
-
segfault authored
Changes of the IsActive and IsEnabled properties were signaled with the same PropertiesChanged signal, causing the UI to briefly display an "inconsisteng state" error. We now signal changes of IsEnabled, IsActive and HasData all with the same signal.
-
segfault authored
-
segfault authored
Move the sync call after the mount call to ensure that we still raise a MountException first which is what the tests check for.
-
segfault authored
-
segfault authored
Activation errors are now encoded by IsEnabled being true and IsActive being false.
-
segfault authored
-
segfault authored
The methods should be idempotent now, so instead of refreshing the state at the beginning (which is quite costly) and raising an error, just do the activation/deactivation again.
-
segfault authored
-
segfault authored
The semantic is similar to systemd units: * IsEnabled means the feature is configured to be activated on boot * IsActive means it's currently active
-
segfault authored
This required: * Adding a translatable name to the features in the backend * Making the greeter able to translate to the currently selected language via a global gettext function which now lives in config.gettext. This was required because before, all translations were really only done by TranslatableWindow which translates all its labels automatically - but it translates the full label string, which doesn't work when the label is composed of multiple strings which must be translated separately, like the feature names we want to include in the message (because we can't make translators translate the complete error message for all possible combinations of features).
-
segfault authored
And use the subtitle of the HdyActionRow.
-
segfault authored
And remove the GtkExpander. It still doesn't look good, the space between the first and second row is too big but we can't change that unless we stop using HdyActionRow.
-
segfault authored
-
segfault authored
Closes #19368
-
segfault authored
It was confusing for users that the error message said "Failed to activate the Persistent Storage" even though most of the Persistent Storage features worked as expected.
-