This is better solved in b74c4b10

This reverts commit d1a7ab61.

This fixes c2ff2ef7 and ca66694b, which together make it displayed forever

Conflicts:
	onioncircuits

The fix in 9043a5a8 didn't work with stem 1.2 (debian jessie) because it has no
stem.DescriptorUnavailable exception. Use more generic stem.OperationFailed instead.

Will-fix: #11195

When using briges, nickname may be initially None. This used to produce an exception.
Use the fingerprint instead.

Will-fix: 11195

* TOR_CONTROL_SOCKET is a path to the control socket file.

* TOR_CONTROL_ADDRESS is the IPv4 address and TOR_CONTROL_PORT is the
  port of the control *port*. If only one of these are specified, a
  sane default will be picked for the other.

By default sane defaults are set for all three of these, so this is
only a mechanism to override them for non-standard configurations.

Both the socket file and port will be tried, in that order.

While avoiding introducing new terminology (cf. d68002ce).

This reverts commit ca66694b.

Otherwise it's not possible to hide the infobar even after Tor is
connected.

Conflicts:
	onioncircuits

Will-fix: #11302

Thanks jvoisin for the patch

This should make the window resizeable to any size.

Will-fix: #11192

When using a bridge, the first node in the path doesn't have a
ServerDescriptor. We now handle this case gracefully.

Make sure that onioncircuits can still display useful results without
tor-geoipdb installed.

Based on the patch from Sascha Steinbiss <sascha@steinbiss.name>

'stream' is the internal Tor terminology but 'connection' is a more
common term.

These labels are probably not really needed...

- When not connected to Tor the infobar should always remain visible as
  Onion Circuits is not usable.
- When connected to Tor there shouldn't be any infobar, see c2ff2ef7.

Onion Circuits is probably simple enough not to need an extra
description of what it is about here.

I don't like introducing the 'path' terminology to mean 'circuit or
stream' and clicking on both a circuit or a stream produce the same
effect, so let's simplify this here.

- We shouldn't make a difference between "connected to Tor" and
  "connected to Tor daemon" as this probably doesn't make sense to most
  users. Also, both things are meant to occur simultaneously. See also
  #11290.
- Remove the second sentence as reconnecting automatically is what you
  expect from Onion Circuits and you also have no agency on this.

The way we use Transifex, we need to point Tor people to a POT file in
Git that they can regularly pull. I see that Onion Circuits has no such
file in Git. It's a bit sad to store such auto-generated files in Git,
but it's even more sad to ship software without translations.

refs: Tails#11173

Thanks to Sascha Steinbiss <sascha@steinbiss.name>.

This prevents a PyGIWarning on startup

With bad network conditions, stem sometimes sends the circuit closed event twice. When recieving the 2nd
of these events, Tor Monitor used to add the circuit that had beeen removed from the list by the 1st.
Will-fix: 10517