Skip to content

Revert "Enable debug logging in the tps backend by default"

intrigeri requested to merge 19948-revert-always-on-debug-in-tps into stable

This reverts commit 91bdd6af.

Our motivation for this is:

  • In several cases we've leaked sensitive or even critical info via debug logs, as part of developing the new Persistent Storage. It's not reasonable to expect developers to always remember this.

  • amnesia -level adversary can read debug logs via tails-debugging-info (#19997 (closed))

And my research on #19948 (closed) concluded that debug logging was not needed to identify the last batch of bugs I found in tpsd; also, I'm reasonably confident the extra info we get from debug logging in these bug reports won't particularly help fix the bug.

Closes #19948 (closed)

Merge request reports