ruff-changed-files CI job checks files that have changed in the target branch
I understand the goal of ruff-changed-files is to check whether the branch we are considering merging introduces regressions. But currently it seems to check any file that differs between that branch and the target branch, e.g. https://gitlab.tails.boum.org/tails/tails/-/jobs/131761 fails because of files that have changed in stable
but not in master
.
To fix this, I think we should bring back the ...
that was removed in f3cac0e1, perhaps with something like this:
--- a/bin/test-utils/ruff
+++ b/bin/test-utils/ruff
@@ -34,7 +34,7 @@ else
RUFF_CMD="check"
fi
-changed_files=$(git diff --name-only "${REF}")
+changed_files=$(git diff --name-only "${REF}"...)
untracked_files=$(git ls-files --others --exclude-standard)
all_files="${changed_files}"$'\n'"${untracked_files}"
cc @segfault and @boyska who were involved in !1449 (merged) and have more context than me.
When we fix this:
-
Fix in master so that !1512 (merged) and #18003 benefit from it -
Forward-port the fix to stable
Edited by intrigeri