Test suite step "the clearnet user has not sent packets out to the Internet" is now irrelevant to Unsafe Browser
This test should be about ensuring the Unsafe Browser does not call home by itself. It does so by checking the iptables
counter for a specific user. It used to be meaningful, but now it's moot.
The following discussion from !956 (merged) should be addressed:
-
@intrigeri started a discussion: (+1 comment) -
the clearnet user has not sent packets out to the Internet
test suite step does not test what we want in its scenario anymore
-
In fact, it was supposed to check for the proper behaviour of the Unsafe Browser. But the Unsafe Browser doesn't run as clearnet
anymore!
-
stop checking traffic from clearnet
user, and check traffic fromveth-clearnet
instead -
add an Anti test for this. For example, we might want to check that using the Unsafe Browser lead that same counter to be strictly positive
Edited by boyska