Reconsider error-prone use of tuples vs. lists in tca-portal
In 7518cdaa I fixed a regression that was introduced by d0de0505, which shows how tuples are subtle (pun intended) to use as a substitute for lists. I'm worried that sooner or later, someone will remove one of these extra commas, thinking they're not necessary, and introduce a similar regression.
I don't understand the implicit rationale behind d0de0505, actually. That commit also makes my IDE mad because the first argument to UserCommand
is supposed to be a List[str]
, but we pass it a tuple instead.
Could we make all this consistent with our typing declarations and less error prone?
cc @boyska