release_process: clarify PACKAGES_MANIFEST vs. build-manifest
Originally created by @CyrilBrulebois on #16465 (Redmine)
It’s already bitten several times, even if I didn’t remember the details during my last ticket filing spree.
The PACKAGES_MANIFEST
variable is misnamed, as one could think it’s
about the `.packages` file while it’s really about the
`.build-manifest`!
Two (complementary) things that can be improved here:
- rename that to
BUILD_MANIFEST
for clarity - improve the check right after defining the desired variable. Right now we only check the file’s existence. But then it’s used this way:
wiki/src/contribute/release_process.mdwn-* Prepare tagged snapshots of upstream APT repositories:
wiki/src/contribute/release_process.mdwn-
wiki/src/contribute/release_process.mdwn: ./bin/tag-apt-snapshots "${PACKAGES_MANIFEST:?}" "${TAG:?}"
and ./bin/tag-apt-snapshots
can be quite unhappy about being fed one
file instead of the other.
If that command isn’t used for anything else, maybe it could check the file extension, which would spot trivial issues like the one I’ve gotten into? That plus the simple variable renaming should be robust enough to me.
Feature Branch: https://salsa.debian.org/tails-team/tails/merge_requests/37#note_108671