geb authored Jul 06, 2020 and intrigeri committed Jul 21, 2020

As tails-spoof-mac is running as root, its messages cannot be translated
according to the user settings. This commit solves this problem by reading the
localization settings from the environment (/etc/default/locale) in
tails-spoof-mac initialization. To make this work, we also set up the desired
localization environment before launching tails-unblock-network and
tails-spoof-mac.

Merge branch 'wip/bugfix/17784-make-MAC-spoofing-failure-msgs-more-useful-and-resilient' into 'stable'

Include in MAC spoofing notification failures a network card name that users can relate to

See merge request tails/tails!69

On MAC spoofing failure, include the name of the disabled network card in the title of the notification

That was the intention since 988b4186
but in that commit, we forgot to replace gettext with eval_gettext
when introducing variables in the translatable string. Let's fix this
and accordingly, drop the test suite workaround for this bug.

refs: #17784

Fix Unsafe Browser automated test in Farsi

See merge request tails/tails!87

This will ease my review of !70 and future work on the panic mode
code paths.

Before 91674552, FindFailed inherited
from RuntimeError, but it now inherits from StandardError,
so we did not catch this exception anymore, and thus:

 - The scenario aborted immediately, instead of testing other locales.

 - We lacked the nice "Unsafe Browser failed to launch in the following
   locale(s): " message ⇒ need to read debug.log to figure out which
   locale failed.

This commit does *not* fix another problem though: if the Unsafe Browser did
start but the expected startup page is not visible, then we would
leave it open and testing the next language will fail.

It's a known-special case, due to advertising the homepage to be RTL, while
actually having English text (until those strings are actually translated),
which results in weird behavior. Better ensure our test suite always exercises
this case, rather than see the occasional seemingly random test failure, that
cannot be triaged without looking at the debug log.

Merge branch 'stable' into wip/bugfix/17784-make-MAC-spoofing-failure-msgs-more-useful-and-resilient

boyska authored Jul 17, 2020 and intrigeri committed Jul 20, 2020

A bug in the rendering of dots in RTL languages provoked an unrelated
test case to be broken. This fixes the problem removing the dot from the
image, so that it displayed incorrectly is less than a problem.

Fix ShellCheck errors in our shell code base

See merge request tails/tails!82

This reverts commit b4c45ad9.

Delegate the discover of interface names to udev, instead of relying
on reading and parsing /sys and lspci ourself, to make the discover
more resilient to missing files, bus agnostic (allowing to discover
non PCI devices like USB ones), and explicit (using udev's own hwdb).

doc: remove Random username generation

See merge request tails/tails!85

Test suite: remove @fragile tags that were mistakenly reintroduced

See merge request tails/tails!76

Since #16744 and 6a198e7a, there is
no random username generation in pidgin anymore. This patch remove
the relevant documentation part, that was apparently left in #17190.

Update the persistence-setup test suite: we added a new preset for Welcome Screen settings

See merge request tails/tails!81

Doc: make "Testing persistence-setup" clearer

See merge request tails/tails!84

I have a feeling this shouldn't have worked like that, but now it works
and previously it wasn't working, so...

They are not run from root directory, now the code blocks are more
copy-pastable. Also, the wording is hopefully a bit clearer.

This reverts commit aaecedbf.