1. 20 Jun, 2021 2 commits
    • Carsten Schoenert's avatar
      d/thunderbird-wrapper.sh: Use '${}' syntax for variables · 07fb6efb
      Carsten Schoenert authored
      Just a formal correction for the previous commit. Enclose variables
      within {} signs.
      07fb6efb
    • Kevin Locke's avatar
      d/thunderbird-wrapper.sh: Make gdb call more fail safe · d003e26e
      Kevin Locke authored
      
      
      Running `thunderbird -g` produces the following error:
      
          INFO  -> Starting Thunderbird with GDB ...
          INFO  -> LANG= /usr/bin/gdb -ex "handle SIG38 nostop" -ex "handle SIGPIPE nostop" -ex "run" /usr/lib/thunderbird/thunderbird
          /usr/bin/thunderbird: line 254: /usr/bin/gdb -ex "handle SIG38 nostop" -ex "handle SIGPIPE nostop" -ex "run" /usr/lib/thunderbird/thunderbird : No such file or directory
      
      This occurs because exec is passed a single argument, which it
      interprets as a file name that does not exist.  Instead, use the
      following steps:
      
      1. Build a command string which combines ${TB_GDB_DEFAULT_OPTS} and
         ${TB_ARGS[@]} (using `printf ' %q'`).
      2. Print the command string with output_info.
      3. Run it using `eval` (for word splitting) and `exec` (to replace the
         shell process with gdb, as before).
      
      Signed-off-by: default avatarKevin Locke <kevin@kevinlocke.name>
      d003e26e
  2. 16 Jan, 2021 2 commits
  3. 15 Dec, 2020 1 commit
  4. 19 Nov, 2019 1 commit
    • Carsten Schoenert's avatar
      /u/b/thunderbird: export variable DICPATH before start · fe289ecd
      Carsten Schoenert authored
      Thunderbird >= 68.x use some other type functionality to include sytem
      wide installed dictionaries.
      We need to give the variable DICPATH the path to the folder where the
      dictionaries can be found.
      
      Thanks to Raphaël Bleuse for the pointer!
      
      Closes: #944295
      fe289ecd
  5. 03 Oct, 2018 1 commit
  6. 02 Dec, 2017 1 commit
  7. 25 Nov, 2017 2 commits
    • Carsten Schoenert's avatar
      [buster] tb-wrapper: searching the correct dbgsym package · 6fff70c7
      Carsten Schoenert authored
      After commit 611a7047 we build now a
      package thunderbird-dbgsym. So we need to search for this package
      instead of the old dbg package.
      6fff70c7
    • Carsten Schoenert's avatar
      tb-wrapper: starting thunderbird-bin instead thunderbird · 6dd6fdbe
      Carsten Schoenert authored
      Upstream is building the binary 'thunderbird' but install this as
      'thunderbird-bin' and is doing later some magic to also copy
      'thunderbird-bin' back into 'thunderbid' inside the installation folder.
      It looks more naturally Thunderbird needs to be started by calling
      thunderbird-bin in the wrapper script, particularly as the binary is
      doing some self checking how it was called.
      Some users reported they had issues to start Thunderbird by calling
      
        /usr/lib/thunderbird/thunderbird
      
      but did have success by calling instead
      
        /usr/lib/thunderbird/thunderbird-bin
      
      The starting wrapper script got modified in that way to always call now
      'thunderbird-bin'.
      
      Closes: #882122
      6dd6fdbe
  8. 12 Apr, 2017 1 commit
  9. 08 Apr, 2017 2 commits
  10. 27 Mar, 2017 1 commit
    • Carsten Schoenert's avatar
      tb-wrapper: correct check for -dbg package · 9f6b7712
      Carsten Schoenert authored
      We need to adjust the check for the thunderbird-dbg package, the
      original aproach isn't usable any longer. Using instead a dpkg query to
      detect if thunderbird-dbg is installed.
      
      Closes: #858804
      9f6b7712
  11. 26 Mar, 2017 1 commit
  12. 14 Mar, 2017 1 commit
    • Carsten Schoenert's avatar
      tb-helper: pass arguments by using a array to TB call · c9960e5e
      Carsten Schoenert authored
      The approach in c2a1d77d wasn't the
      right attempt, as explained by Simon and Daniel in #855334 the best
      solution is to use a Bash array that's taken as argument for the TB
      binary call.
      It's not only more simple, it's also more secure than to use eval for
      variable expansion, really bing thanks for explaining this potential
      security problem goes out to Simon here! Really appreciated.
      But also thanking Daniel for providing a patch with the needed
      structural changes!
      c9960e5e
  13. 11 Mar, 2017 1 commit
    • Carsten Schoenert's avatar
      tb-helper: pass arguments correctly through tb call · c2a1d77d
      Carsten Schoenert authored
      Given arguments that are not targeted for the wrapper script itself
      needs to through the script and passed as given to the final call of the
      Thunderbird binary. This needs the usage of the extra function call
      'eval' to expand the given arguments first.
      
      We also parse the arguments as a list instead on based the given
      argument count. This saves a little bit time, the can loop directly
      through the elements of list.
      While looping through the arguments we search for escaped arguments and
      "restore" this escaping as it is removed bx the shell. Doing this also
      for arguments that containing some other special characters like equal
      signs and commas. Some possible arguments for the thunderbird binary use
      them. For example
      
        thunderbird -compose "to='recipient@tld.org','attachment=some.file'"
      
      And doing some more escaping of used variables inside the script.
      
      Closes: #855334
      c2a1d77d
  14. 08 Mar, 2017 1 commit
    • Carsten Schoenert's avatar
      tb-helper*: fix up that silly comments behind the if statement · 24d25e94
      Carsten Schoenert authored
      A stupid error happen in the if statement while checking for existing
      folders .icedove and .thunderbird doing work for commit
      c9e5b708
      
      The comment behind the if check is of course intepreted by the Bash as
      we have a backslash '\' in the if condition to ignore the line break
      here. By this the check wasn't working correctly and assumes the check
      is failing and informs the user for a not valid folder situation.
      
      Closes: #857029, #857032, #857098, #857112
      24d25e94
  15. 04 Mar, 2017 6 commits
    • Carsten Schoenert's avatar
      tb-helper*: call subfunctions not within the case loop · 101e0ada
      Carsten Schoenert authored
      To give users a chance to add e.g. --verbose option after typing
      --show-backup we need to first looping all given options within the case
      loop and decide later given on the flags what to do.
      101e0ada
    • Carsten Schoenert's avatar
      tb-wrapper*: complete rework and moving over for symlinking · c9e5b708
      Carsten Schoenert authored
      The two helper scripts got completely restructured to fit into the idea
      we do a symlinking of .thunderbird to .icedove in the users home.
      To goal this the various steps got break of into subfunctions that are
      called from the main wrapper helper script /usr/bin/thunderbird.
      
      Also adding some extra wrapper option to get the fixing for the MIME
      part also available ouside the profile adption. This commit is made also
      from contribution of Debian fellows.
      Thanks go out to Jens Reyer who contributed not only patches but also
      checking the script against the shellcheck tool and by doing the needed
      testing of this whole stuff!
      
      The logic for the adoption is hopefully simple.
      If there is no folder or already symlinked ~/.thunderbird folder to
      .icedove we can simply create the link to ~/.icedove.
      If we check there is a existing symlink ~/.thunderbird and isn't pointing
      to ~/.icedove we error out then.
      
      Closes: #855265, #855391, #855501, #856490
      c9e5b708
    • Carsten Schoenert's avatar
      tb-helper*: rework option parsing for wrapper script · e0331e1f
      Carsten Schoenert authored
      Using the option seperator '--' in the thunderbird-wrapper script isn't
      usable, it breaks other scripts and caller functions.
      To not break other stuff removing the getopt functionality as we need to
      collect the possible mixed up options given to the wrapper script and
      split them of.
      
      Thanks Guido Günther for getting the basic while loop for handling this.
      
      Closes: #855872
      e0331e1f
    • Carsten Schoenert's avatar
      tb-helper*: wrapping X11 dialog calls · 3089a971
      Carsten Schoenert authored
      We can improve the the usage of the possible X11 dialogs if we add some
      sanity checks and also adding a fallback mechanism if some call to
      kdialog or zenity is failing.
      3089a971
    • Carsten Schoenert's avatar
      thunderbird helper: split helper function into extra file · 97343499
      Carsten Schoenert authored
      To improve the readability of the starting wrapper script let's split
      off all the helper stuff like local functions, static strings and some
      checks. The plain wrapper script for /u/b/thunderbird get consolidated
      and compacted by this.
      
      Also adding the Mate DE to the detected environments we can run on, as
      suggested by #855286.
      Adding the 'mate' string to the zenity call if detected. We still need
      to add some sanity checks if zenity or kdialog available.
      
      Closes: #855286
      97343499
    • Carsten Schoenert's avatar
      thunderbird-wrapper.sh: fix command line transfer to TB · dc878e7a
      Carsten Schoenert authored
      The old behavior of passing all arguments into a single string by using
      the variable THUNDERBIRD_OPTIONS isn't working well and not as expected.
      We can instead use $@ directly.
      
      Thanks dkg for preparing that fix!
      
      Closes: #855334
      dc878e7a
  16. 14 Feb, 2017 1 commit
  17. 13 Feb, 2017 2 commits
  18. 09 Feb, 2017 1 commit
  19. 29 Jan, 2017 1 commit
  20. 17 Jan, 2017 1 commit
  21. 14 Jan, 2017 1 commit
    • Carsten Schoenert's avatar
      thunderbird-wrapper.sh: also migrate mimeapps.list · a272f853
      Carsten Schoenert authored
      It's also a good idea to change existing MIME associations with the
      icedove desktop within $(HOME)/.config/mimeapps.list as Laurent
      Bigonville pointed out.
      
      Improving the script a bit more so it will not going further and try
      things which can lead to a inconsist old profile folder depending on
      ignoring the first error.
      
      Closes: #850864
      a272f853
  22. 17 Dec, 2016 1 commit
    • Carsten Schoenert's avatar
      thunderbird-wrapper.sh: adding fixing inside mimeTypes.rdf · da402a47
      Carsten Schoenert authored
      The file 'mimeTypes.rdf' may have registered /usr/bin/iceweasel for
      various application like http and https. This is no problem as long as
      the user isn't removing the transitional iceweasel package which is
      providing a symlink from /usr/bin/iceweasel -> /usr/bin/firefox.
      
      So this commit is fixing this by changing all old entries for
      /usr/bin/iceweasel with /usr/bin/x-www-browser which is pointing to the
      prefered browser. This is only done while the profile migration is done.
      If a user isn't using this automatism and is moving the profile folder
      by hand the modifying of 'mimeTypes.rdf' has to also done manually.
      
      Thanks to Jens Reyer who figured this problem and the solution out!
      
      Closes: #837516
      da402a47
  23. 10 Dec, 2016 1 commit
    • Carsten Schoenert's avatar
      de-branding: (re)adding a wrapper script for TB starting · 0c9a6ab1
      Carsten Schoenert authored
      Because of the de-branding the profile for Thunderbird has changed back
      to the Mozilla default $HOME/.thunderbird.
      
      Related to the old branded binary name Icedove the profile folder
      $HOME/.icedove was previously used. To get a uninterrupted workflow for
      the user while going back to a Thunderbird package we have to take care
      about the profile migration to the new profile folder.
      
      This commit creates a wrapper script that will do this migration of the
      user data. It's purpose is to act as a wrapper while calling
      /usr/lib/thunderbird/thunderbird through /user/bin/thunderbird.
      It will also handle a easier handling for creating gdb logs if needed.
      Other debuggers can be added to but not yet or probably never. Right now
      we never had the need to provide a valgrind build of Icedove or
      Thunderbird. Any help is appreciated here.
      0c9a6ab1