Implement "Connect to Tor" button in error screen
Closes #18382 (closed), #18364 (closed)
What it does (and what should the reviewer test):
- change the error screen to follow more closely sajolida's mockup
- no new functionality, just better UX. The only minor new functionality is if the user needs both to set a proxy and open a captive portal; it was not possible previously, now it is.
Extra things that would make it better:
-
if the user clicks on "configure a local proxy" but then doesn't change anything, this shouldn't be counted as a "fix_attempt" -
when calling "try signing in to the network" we should check if that is possible; if it is not, this shouldn't be counted as a "fix_attempt" this is slightly harder, so it will probably be postponed. -
put the current bridges in the textarea (if any) -
better alignment, spacing, etc.
Those improvements are nice, but this MR is still an improvement over the current testing branch.
Edited by intrigeri