tails_persistence_enabled? has buggy use of single-quotes and #{...}
Originally created by @anonym on #8919 (Redmine)
The function tails_persistence_enabled?
in
features/step_definitions/usb.rb
has this line:
@vm.execute('. #{persistence_state_file} && ' +
The single-quotes should make it so that #{persistence_state_file}
is
interpreted literally, not evaluated etc. We want double-quotes here.
How can this function possibly work? It seems to do so since it uses
both its true
and false
case in various steps. However, my reading
is that it should always return false
since . #{persistence_state_file}
should evaluate to false in the shell.
Feature Branch: bugfix/8919-fix-tails_persistence_enabled