Improve how we pass data between steps
Originally created by Tails on #5847 (Redmine)
See e.g. the changes commit 61928d8 brings to
There the class variable
gnupg_recv_key_res is used between steps.
Imagine if the step that assigns it (i.e.
I fetch the ... OpenPGP key...) is done before the background snapshot is saved, and some step
GnuPG uses the ... keyserver...)
is done after the background snapshot is restored. It will work for the
first scenario, but in the following scenarios
be empty, because class variables are cleared between scenarios.
Perhaps steps like these should only be allowed either when no background snapshot is used, or after the background snapshot has been restored? That could be achieved by putting the following at their beginnings:
raise if @skip_steps_while_restoring_background
Or we don’t allow using class variables between steps them at all, and
instead we have to use global variables (i.e.
which are not cleared ever.
Feature Branch: test/5847-fix-global-vs-class-variables-issue
Parent Task: #10237 (closed)
- Blocked by #6094 (closed)