get rid of the restart Tor launcher
Originally created by Tails on #5331 (Redmine)
It’s been observed by some people that the NEWNYM button in TorK was sometimes not effective enough to get a new identity, e.g. a new circuit was actually not established, or at least the exit node did not change.
This is why a "Restart Tor" launcher has been put, as a quick’n’dirty workaround, to the Gnome panel.
This issue needs to be investigated further. If there is a real bug behind this, it has to be reported to Robert Hogan (the TorK maintainer).
Seems like TorK’s NEWNYM button actually works as it is supposed to: any new established connection goes through a new circuit. There can be an annoying misunderstanding, though: as old circuits are still displayed, and probably used for pre-existing connections, one can easily fear the NEWNYM feature did not work. Vidalia is more explicit wrt. this feature: it explicitly tells the NEWNYM applies to new connections only. Let’s wait until we ship Vidalia instead of TorK, before removing this launcher, then!
Ok, we now ship Vidalia. But quite often, Tor fails to fetch enough data to establish a working connection, and restarting it almost always works. I’m then wondering whether we can really afford removing this launcher => todo/discuss.
Removed it anyway for next release, let’s see what the users’ feedback is like.
Seems like the Tor bootstrap issue mentioned above was caused by the tor vs networkmanager bug => done.