Selecting default bridge type in Tor Connection is broken

Two discussions from !2271 (merged) should be addressed:

• @boyska started a discussion: (+1 comment)

  Here's a thread to merge a UX glitch which is currently invisible, but might become visible in the future.

  When the user wants to use default bridges, and there is more than one kind of default bridge that we support, TorConnection displays a dropdown. Right now it doesn't, because there is only obfs4. But if webtunnel bridges are added to default bridges, then this will be displayed.

  Fact is: the ComboBoxText just doesn't work. I have spent a lot of time investigating that, and come to conclusions that it depends on the fact it is inside a RadioButton. For some reason, that prevents it from working. If I move it somewhere else, it works. I also tried moving to a different implementation of the same concept (Gtk.ComboBox, Handy.ActionRow, Adw.ListBoxRow) with no success.

  I see those options, sorted by increasing implementation cost:

  • we ignore the problem until it actually happens that a webtunnel is added to default bridges. maybe it will never happen, so why bother? And when it happens, it's ugly, but not really a regression.
  • we never let the user choose the kind of default bridge. this simplifies the UI!
  • we change the UI in a way which still looks similar, so the ComboBoxText would be on the right. because of how layout works in Gtk, this might mean that the text gets truncated differently
  • we change the UI in a deeper way, redesigning that page. I'm not sure why we should do that

Second discussion is !2271 (comment 263752) :

Could we [...] write Use a default *$bridge_type* bridge when there is only 1 type of default bridges?