tails-additional-software-upgrade.service systemd dependencies are incorrect
@intrigeri started a discussion: (+2 comments)
The need for this suggests we have the dependencies wrong on this unit, and quite possibly on the corresponding path unit. Indeed, they have
After=
ordering, but no actual dependency declared.I think that instead of adding this manual dependency management via
ExecStartPre=
here, we could instead addRequisite=tails-tor-has-bootstrapped.target
to both units. This might require some care wrt. what happens in case something happens while the upgrade is applied, which causes tor to go down: we don't want to kill apt/dpkg too forcibly :)
This could explain some of the Additional Software upgrade failures users are reporting.