Clean up pre-TCA leftovers
I see obsolete references to Tor Launcher in comments in:
config/chroot_local-hooks/99-permissions
config/chroot_local-includes/etc/NetworkManager/dispatcher.d/10-tor.sh
config/chroot_local-includes/etc/tor/torrc
config/chroot_local-includes/lib/systemd/system/tor@default.service.d/writable-etc-tor.conf
config/chroot_local-includes/usr/bin/tor-browser
config/chroot_local-includes/usr/local/lib/tails-shell-library/tor-browser.sh
config/chroot_local-patches/apparmor-adjust-tor-profile.diff
Apart of this:
- The TODO in
config/chroot_local-includes/etc/onion-grater.d/tor-connection-assistant.yml
is outdated since 6295631d, isn't it? -
exec_unconfined_firefox()
is not used anymore, so we could remove it and the copy of the Firefox binary we create inconfig/chroot_local-hooks/10-tbb
- I see a reference to a
tor-sandox-helper
script that does not seem to exist, which makes the surrounding comment confusing. - I see "XXX: added temporarily for the 17215-tca-always-started branch". Please track this with an issue and reference it in that comment.
- Wrt. "XXX: We can drop the if-statement and keep just its body once", I don't understand why this needs to wait for a stable release. Either way, this should have happened once we start working on this issue, so here's a note to clean this up.
- I see some more "XXX" added in the test suite between 4.18 and 4.19 about bugs in TCA. At least one of them can affect users ⇒ please track them on dedicated issues referenced in these comments.