Closing and reopening TCA might lead to different state
As seen in !446 (merged) , TCA behaves differently when closing and reopening it. The main status in which there is inconsistent behavior is the distinction between progress and error. In fact, TCA assumes than an error is just a progress that hasn't reached success for $TIMEOUT seconds.
In other word, the user will get back to the consent screen if Tor fails to connect after they close it on the progress bar.
Examples:
Scenario 1: Tor Connection goes back to consent after close on progress
- Choose autoconfig on a network without connection to Tor
- Close TCA while on the progress bar
- Notification tells me that closing Tor Connection will not stop the connection to Tor.
- Reopen TCA
- I'm back to the consent question.
Not a big deal. Ideally TCA should go back directly to the progress bar, the success, or the error screen.
Scenario 2: Tor Connection goes back to consent after error
- Choose autoconfig on a network without connection to Tor
- Wait until the error screen
- Close TCA on the error screen
- Notification tells me that closing Tor Connection will not stop the connection to Tor.
This seems more problematic to me because the user can't go back to debugging their connection without going through the long progress bar again.