Fix ShellCheck errors in our shell code base
pabs privately submitted a series of patches that fix ShellCheck errors.
IMO it’s great to get closer to established coding best practices and style guides, and perhaps at some point we can even enforce some basic rules via pre-merge gatekeeper CI. In passing, related effort for our Ruby code: #17646 (closed).
- Related to #17646 (closed)