"SSH is using the default SocksPort" test suite scenario is fragile
Originally created by @intrigeri on #17163 (Redmine)
I’ve initially spotted this on #16792 (closed), and then noticed that it
affected all branches.
For example, this scenario failed 12 times in the last 16 test suite
runs on the testing branch.
In every failed case, SSH immediately fails with “nc: connection failed,
SOCKSv5 error: General SOCKS server failure”.
Interestingly, none of the scenarios in ssh.feature
are affected,
while they do almost the same thing. The main differences are:
- In
tor_stream_isolation.feature
we have the “I monitor the network connections of SSH” CPU hog running. This might make it harder for tor to do its job. - In
ssh.feature
, we useretry_tor
so we retry up toMAX_NEW_TOR_CIRCUIT_RETRIES
(default: 10); while intor_stream_isolation.feature
we only try once.
In short, the fragile scenario runs in a context that makes it more likely to fail, and does not retry.
Feature Branch: test/17163-ssh-stream-isolation+force-all-tests
Related issues
- Related to #17013 (closed)
- Related to #16792 (closed)
Edited by intrigeri