Persistence config files "insecure" backup get emptied in some situations
As we can see on #10976 (comment 64669) and #10976 (comment 64649), if the
permissions/ownership of the root directory of the persistent filesystem
live-additional-software.conf.insecure_disabled ends up
being empty, which is unfortunate as it’s meant to be a backup that the
user can later restore by hand.
I believe that’s because every call to
rename the current
live-additional-software.conf.insecure_disabled. So if the user
immediately fixes the problem, the first time it happens, then we’re
good. But if they reboot and unlock their persistence again, the
(non-empty) backup gets overwritten by
live-persist which replaces it
with the new, empty config file it created during last boot.
not replace a non-empty
.insecure_disabled backup file with an empty
Priority >> normal because it makes it harder to recover from the already painful #10976 (closed).
Note: I don’t understand why, in Cody’s report, the same problem did not
persistence.conf. There might be another problem on top of
this one. But this should not block it from fixing the problem I’ve
already understood here :)
Feature Branch: bugfix/17112-dont-empty-persistence-config-backup