Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T tails
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 971
    • Issues 971
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • tails
  • tails
  • Issues
  • #16150
Closed
Open
Issue created Nov 23, 2018 by bertagaz@bertagaz

After hooks should be able to mark the scenario as failed in Jenkins Cucumber report

Originally created by @bertagaz on #16150 (Redmine)

While noticing #16148 (closed), it appeared that a failing @check_tor_leaks hook does not mark the concerned scenario as failed in Cucumber’s JSON output. This is only about the JSON output: on the stdout/stderr and exit code front, the test suite and Cucumber bits behave as intended and the scenario is correctly considered as failed.

The Cucumber JSON output only records per-step status, not per-scenario status, and it does not take into account the After('product’, ’check_tor_leaks') cucumber hook that runs our code. This leads to bad and misleading reporting by the Jenkins cucumber report plugin, that relies on Cucumber’s JSON output. We should make it so that a failing check_tor_leaks hook ensure the scenario is recorded as failed in Cucumber’s JSON output.

Attachments

  • cucumber.json

Related issues

  • Related to #9424 (closed)
  • Related to #16959 (closed)
  • Has duplicate #16768 (closed)
  • Blocked by sysadmin#17080 (closed)
Edited May 21, 2020 by bertagaz
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking