Clean-up: remove obsolete Thunderbird check
During the preparations of Thunderbird 60, we noticed that the language
packs had a strange
firefox.mozilla.org suffix, which could turn into
the more normal-looking
thunderbird.mozilla.org one. We added a check
because we had some local code to try and enable localization again:
commit ad91a77ee8cc84ca4ac212da7f0a77b606224863 Author: Cyril Brulebois <firstname.lastname@example.org> Date: Wed Aug 15 11:18:53 2018 +0200 Thunderbird: check the lang packs are suffixed @firefox.mozilla.org (refs: tails/tails#15091). It was slightly surprising to spot @firefox.mozilla.org as a suffix instead of the traditional @thunderbird.mozilla.org one. This was reported to Debian#906176 (https://bugs.debian.org/906176). Let's check how many language packages are found with the suffix used in tails-shell-library/thunderbird.sh, to make sure l10n has a chance to work.
but we don’t need this anymore since:
commit 25c302e2449c20970bc93c11cadbafc09c04fe68 Author: anonym <email@example.com> Date: Tue Oct 2 17:55:19 2018 +0200 Thunderbird: get locale from environment via intl.locale.requested. It has replaced intl.locale.matchOS. Fix-committed: tails/tails#15942
commit 0c2bfb6ee80b91d6306944ca3c1dcd123cb9772c Author: Cyril Brulebois <firstname.lastname@example.org> Date: Mon Oct 1 16:55:16 2018 +0200 Revert "Thunderbird: Import locale selection handling from Tor Browser (refs: tails/tails#15091)." (refs: tails/tails#15959). This reverts commit 01df272943269352358aa1974cb6d90ddb36e926. By merging thunderbird 1:60.0-3 from Debian, we should get a proper setting for intl.locale.requested, which is an empty string. This replaces the old “intl.locale.matchOs = true” behaviour. This also makes our efforts to set this parameter based on the locale settings moot, so let's revert it all and let the built-in code do its job instead.
so I guess we should just remove this check entirely?
The attached patch does that, tested on top of the
branch (itself based on
Feature Branch: bugfix-16422-thunderbird-60.5.1
- Blocked by #16422 (closed)