Custom Desktop launchers are totally buggy

Originally created by @intrigeri on #14793 (Redmine)

They get the default icon instead of the configured one, e.g. tails-documentation.desktop specifies Icon=/usr/share/icons/gnome/48x48/categories/system-help.png, which is installed, but a text file -looking icon is displayed instead.

Their Name= is ignored i.e. the displayed label is e.g. tails-documentation.desktop.

Double-clicking on the icon opens an “Untrusted application launcher” dialog.

All these are caused by the fix for #14584 (closed), that will land in Stretch any time now, so it needs a fix based on our stable branch: if I click “Trust and launch” then the icon and name get fixed and I see no confirmation dialog next time I double-click the same launcher.

I think the fix is to add a trusted attribute in a gio/gvfs metadata, which is stored on the filesystem in ~/.local/share/gvfs-metadata.

I’m not surprised this component is bitrotting, see #13461 (comment 41750) and #11717 (comment 56886).

Feature Branch: bugfix/14783-trust-desktop-launchers

Related issues

• Related to #13461 (closed)
• Related to #11717 (closed)
• Related to #14584 (closed)
• Related to #16283 (closed)