Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • T tails
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 919
    • Issues 919
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • tails
  • tails
  • Issues
  • #12247
Closed
Open
Created Feb 17, 2017 by alant@alantDeveloper

Remove lists of if clauses

Originally created by @alant on #12247 (Redmine)

The greeter code has several ugly lists of if clauses:

        if row == self.listboxrow_text:
            tailsgreeter.utils.popover_toggle(self.text_setting.popover)
        elif row == self.listboxrow_keyboard:
            tailsgreeter.utils.popover_toggle(self.keyboard_setting.popover)
        elif row == self.listboxrow_formats:
            tailsgreeter.utils.popover_toggle(self.format_setting.popover)
        elif row == self.listboxrow_tz:
            tailsgreeter.utils.popover_toggle(self.timezone_setting.popover)

They should be replaced by some metaprogramming, making it easier to add new settings.

Feature Branch: greeter:feature/12247-replace-lists-of-if

Parent Task: #8230 (closed)

Edited May 15, 2020 by alant
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking