GitLab

Suggested-by: ShellCheck
Documentation: https://www.shellcheck.net/wiki/SC2145

Suggested-by: ShellCheck
Documentation: https://www.shellcheck.net/wiki/SC2068

In some cases, the previous code would overwrite a non-empty backup file with an
empty one, making it harder to recover from the already painful #10976.

For example, if the permissions get wrong and we run
disable_and_create_empty_persistence_conf_file(), but the user does _not_
immediately fix the problem, then next time they unlock their persistence,
the (non-empty) backup gets overwritten by live-persist which replaces it with
the new, empty config file it created during last boot.

Currently translated at 17.7% (11 of 62 strings)

Translation: Tails/wiki/src/news/version_3.14.1.*.po
Translate-URL: http://translate.tails.boum.org/projects/tails/wikisrcnewsversion_3141po/pt/

Currently translated at 39.0% (16 of 41 strings)

Translation: Tails/wiki/src/news/version_3.11.*.po
Translate-URL: http://translate.tails.boum.org/projects/tails/wikisrcnewsversion_311po/it/

The fix for #15781 was incomplete as it failed to reset
live-additional-software.conf with correct premissions it they were wrong in
the first place.

Will-fix: #15802

Will-fix: #15781

Will-fix: #15781

On #15692 we instruct users to create preferences/0000tails.js, with the intent
that it would not be persistent because until 3.8 we have code that deletes that
file on persistence activation. But as part of the fix for #15693, I've removed
the code that deletes that file on persistence activation, which was not
necessary to fix #15693.

So a user who follows these instructions during their last Tails 3.8 session
with persistence enabled (before upgrading to 3.9) will have that file left in
persistence once they upgrade to 3.9… and then they'll be stuck forever with an
obsolete value for extensions.enigmail.configuredVersion. To avoid that, I'm
hereby re-adding the code that deletes this obsolete file.

We've done the switch a year ago, in Tails 3.0, and #15693 shows
that this migration code causes issues, so let's get rid of it.

Besides, I have a hunch that this code is the only possible rationale
explanation for the dreaded "empty persistence.conf file" problem, putting aside
user intervention: it's the only piece of code we have, apart of the Tails
Persistence Setup wizard that affected users tell they did not use, that
modifies persistence.conf (refs: #10976).

Enigmail needs this info to know whether it should display its configuration
wizard and trigger other post-upgrade operations. We should let it manage
this value itself, otherwise it will display its configuration wizard
every time one starts Thunderbird in a freshly booted Tails, even if
the Thunderbird data is persistent.

This is too tricky to implement and doesn't add any actual security.

This reverts commit a627b4c3.

Refs: #14595

Refs: #14594

Refs: #14594

This way, we don't need to start python of Additional Software Packages are disabled just to create an empty file

Will-fix: #9059

Whenever persistent Claws Mail setting is enabled, this creates an empty
~/.icedove/ directory, that prevents Thunderbird from starting.

"." is a regexp special char. We mean "." literally so it ought to be escaped.

Wrong:

 $ echo 'user_pref("extensionsXenigmailYconfiguredVersion",' \
   | sed --regexp-extended \
        '/^(user_)?pref\("extensions.enigmail.configuredVersion",/d'

Right:

 $ echo 'user_pref("extensionsXenigmailYconfiguredVersion",' \
   | sed --regexp-extended \
        '/^(user_)?pref\("extensions\.enigmail\.configuredVersion",/d'
 user_pref("extensionsXenigmailYconfiguredVersion",

For any Thunderbird profile that was ever used, that pref will be
present there as well.

Will-fix: #12680

Refs: #12680

Note that the backslash in the removed `\_${pattern}_`-style sed
patterns just says "the next character will be the delimiter", so _
becomes the delimiter. That allows you to use another delimiter than /
in compination with d, which is nice when the pattern is a path (that
tend to include /). It's a little known sed-feature. Just FYI! :)

This reverts commit b3abf4e5.

Also, tails-persistence-setup 1.1.8-1 has been uploaded to our APT
repo, which has adjusted for this migration.

Will-fix: #12242

The problem was not that live-persist must error out when read-only
persistence is activated rather than issue a warning. In the bug raised
by #10431, the problem was that it *already did* because it tried to
make the new persistence config anyway. So fixing #10431 by erroring out
just lead to the same situation.

In this case, we don't want to error out but warn out that the migration did not
happen, and just go on with the boot without trying to migrate anything.

Will-fix: #10431