GitLab

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/Themes#Documentation
says that "Lightweight themes have been deprecated", which explains why our old,
custom lightweight theme is ignored.

The only options to fix this are:

 - Create our own theme, get it automatically signed by Mozilla on AMO, download
   the resulting XPI, and somehow make it available at build time.

 - Use an existing theme with a GPL-3+ compliant license.

I've chosen the latter option: this theme is almost identical to the one we
had before.

The XPI is 7.7K so I don't think it's worth devising a more complicated
solution than just adding it to Git.

Currently translated at 17.7% (11 of 62 strings)

Translation: Tails/wiki/src/news/version_3.14.1.*.po
Translate-URL: http://translate.tails.boum.org/projects/tails/wikisrcnewsversion_3141po/pt/

Currently translated at 39.0% (16 of 41 strings)

Translation: Tails/wiki/src/news/version_3.11.*.po
Translate-URL: http://translate.tails.boum.org/projects/tails/wikisrcnewsversion_311po/it/

Assigning _ to gettext.gettext in the module to make syntax checkers
happy was rendering the version provided by gettext.install
inaccessible.

Will-fix: #16601

It seems like the perl library which previously nicely handled the tps
command-line arguments now doesn't support taking dashes instead of
underscores anymore.

This way tails-additional-software-notify will open a browser with
propoer "GNOME" environment no matter who calls it.

We lacked sufficient environment for AT-SPI to work for the browser
child processes started for browsing the docs.

This fixes dialog width and height on Buster:
https://gitlab.gnome.org/GNOME/zenity/commit/3b64d05e8a1aae1581d2bec7288d80ac4699e1b1

People get confused by the use of pal/neutral/foe: they think we need
to particularly trust members of the "pal" pool, which is incorrect
and can lead to useless controversy.

So let's fix this by renaming the pools and clarifying our design doc.

Will-fix: #15983

Convert packages names to set as map objects sometimes don't
behave as expected.

Will-fix: #15983

Will-fix: #15838

Will-Fix: #15838

assert is only evaluated if __debug__ is True and should not be used to check
for conditions.

Will-fix: #15838

Will-fix: #15838

Will-fix: #15838

Will-fil: #15838

this comments appear on the translation files and help translators do
their work.

This reverts commit 268e3f78.

Will-fix: #15879

Use a set instead of map object to restore intended behaviour of filter and
intersection.

Will-fix: #15822

Will-fix: #15822

Will-fix: #15822

Will fix: #15822

The fix for #15781 was incomplete as it failed to reset
live-additional-software.conf with correct premissions it they were wrong in
the first place.

Will-fix: #15802

This reverts commit c3631c8b.

Today the build fails for me with:

 The following NEW packages will be installed:
   squashfs-tools
 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
 Need to get 125 kB of archives.
 After this operation, 305 kB of additional disk space will be used.
 Get:1 http://deb.tails.boum.org devel/main amd64 squashfs-tools amd64 1:4.3-3.0tails4 [125 kB]
 Traceback (most recent call last):
   File "/usr/local/sbin/tails-additional-software", line 16, in <module>
     from tailslib import LIVE_USERNAME
 ImportError: cannot import name 'LIVE_USERNAME'
 Fetched 125 kB in 0s (3463 kB/s)
 E: Sub-process /usr/local/sbin/tails-additional-software apt-pre returned an error code (1)
 E: Failure running script /usr/local/sbin/tails-additional-software apt-pre

I'm not sure why it did not fail recently but in any case, I believe the
justification for commit:c3631c8b
("the ASP dpkg hooks are installed in the end of the build, making this code
useless") was based on a misunderstanding:
config/chroot_local-hooks/99-zz-install-ASP-DPKG-hooks is not "the end of the
build" and we do run APT again later. So let's reintroduce the safeguard.

This reverts commit 3460524d.

As explained on https://labs.riseup.net/code/issues/8514#note-58 the commit I'm
reverting was based on a misunderstanding. While it improves things in some
cases, it makes them worse in some other cases. So let's revert it for now
until we reach an agreement on what the test should look like.

Will-fix: #15781

Will-fix: #15781

On #15692 we instruct users to create preferences/0000tails.js, with the intent
that it would not be persistent because until 3.8 we have code that deletes that
file on persistence activation. But as part of the fix for #15693, I've removed
the code that deletes that file on persistence activation, which was not
necessary to fix #15693.

So a user who follows these instructions during their last Tails 3.8 session
with persistence enabled (before upgrading to 3.9) will have that file left in
persistence once they upgrade to 3.9… and then they'll be stuck forever with an
obsolete value for extensions.enigmail.configuredVersion. To avoid that, I'm
hereby re-adding the code that deletes this obsolete file.

Will-fix: #15578