GitLab

We kill a loop and refactor the body into a method, removing twi levels
of indentation because of it. This should also make it easier to write
unit tests for the filter parsing.

It's useful when debugging clients that use several concurrent
connections, like tor-launcher. Then the client port can be used to
distinguish them (otherwise they look identical).

I.e. tell which client did it.

Most of it is about ending the stupid experiment with multiple filters
and merging, so this is a huge simplification made possible by dropping
some functionality of questionable use. One filter to rule them all!

It also adds the `confs` syntactic sugar, and fixes some tiny issues
introduced in recent commits.

And at the same time we make argument rewriting work for SETCONF, which
it doing wasn't before (which was a bug!).

... not whatever length it has today.

So that unsubscribing actually works as intended. OTOH, I think the old
way actually worked since we unsubscribe the same event_cb the correct
amount of times (but the order is undefined, subject to the
implementation of stem's remove_event_listener()), but let's do it
properly instead.

They're handy for frequently typed commands, they are more cryptic which
is something we don't want to encourage.

The other helpers for handle_controlport_session() are defined inside
the its scope, so why not this one?

I knew I shouldn't have committed that crap!