GitLab

… otherwise it appears as "Tor Browser" in the taskbar.

I did not manage to prevent the omnibar from allowing search
so let's simply delete the search plugins, which is the same,
from an end-user perspective, as before: we hid the search bar
via userChrome.css.

I'm not removing this one-liner in userChrome.css though, just in case it's
re-enabled by default at some point via Tor Browser prefs or something.

This does not address the main problem (the name of the app in the taskbar)
but it's a start.

pref() is not honored in prefs.js.

Otherwise it fails to render anything and its window is filled with black.

https://bugzilla.mozilla.org/show_bug.cgi?id=1450169

preferences/0000locale.js is apparently ignored.

We've done the switch a year ago, in Tails 3.0, and #15693 shows
that this migration code causes issues, so let's get rid of it.

Besides, I have a hunch that this code is the only possible rationale
explanation for the dreaded "empty persistence.conf file" problem, putting aside
user intervention: it's the only piece of code we have, apart of the Tails
Persistence Setup wizard that affected users tell they did not use, that
modifies persistence.conf (refs: #10976).

Enigmail needs this info to know whether it should display its configuration
wizard and trigger other post-upgrade operations. We should let it manage
this value itself, otherwise it will display its configuration wizard
every time one starts Thunderbird in a freshly booted Tails, even if
the Thunderbird data is persistent.

This is a follow-up to commit:6b13c981.
An AppArmor profile name can be e.g. "torbrowser_firefox", and not necessarily
the path of the executable that's confined.

Don't give Thunderbird its own TMPDIR anymore and drop the corresponding, incomplete AppArmor profile adjustments (refs: #15610)

The rationale provided for this customization (commit:a1fd1f0f, #9558) does not
hold here: the AppArmor profile allows Thunderbird to access /tmp anyway.

Besides, the AppArmor profile tweaks we had in place to match this custom
TMPDIR were incomplete: for example, as reported on #15395#note-24
this broke importing public OpenPGP keys from email attachments.

- /getting_started is very old and needs a serious lifting.

- During the user testing of the Additional Software beta, 3 out of 5
  participants ended up on this page. None of them read it. 2 used it to reach
  /doc which is what they were looking for. 1 got lost and ended up on /design.

It it's not specified, the Provides field gets an empty string and is
not included in the resulting binary.

Onion Grater: adjust parsing of /proc/pid/attr/current to support named AppArmor profiles (refs: #14572)

Without this changes, passing 'torbrowser_firefox' to the exe-paths setting
is not effective.

It was an oversight that anchor support wasn't implemented in the
python port.

This was dropped when the script was rewritten in Python, presumably becausethe
WebKit viewer does not support it (?). We do use this functionality in at least
one place.

Now that we open the doc in Tor Browser when online, we can re-add this support.

Our website has language negotiation enabled but our Tor Browser pretends
the user prefers English.

Passing the command to be run is not enforced according to the doc,
but still: let's use the documented form.

For easier diagnostics of failing servers.

Patch by Linus Nordberg <linus@nordberg.se>.

This reverts commit d5f2ccf2.

Tor Browser currently enables SELFRANDO "only in non-release builds"
(https://trac.torproject.org/projects/tor/ticket/24912#comment:8).

Will-fix: #15368, #15369

Refs: #5684

This reverts commit 72f96f04.

This fixes that the output of the command includes control characters
for colored output.

Create the GTK widgets in tails-screen-locker instead of using the
glade file. This solves the issue that we don't have a way to generate
.po files from glade files (although there is `xgettext -L Glade`, in
case we ever need it for something else).