GitLab

In gettext-base < 1.8.2, like the one we had in Wheezy, gettext.sh
references the environment variable ZSH_VERSION, which we do not
set. This has prevented us from doing `set -u` in all gettext:ized
shell scripts unless we first initialize that variable before sourcing
gettext.sh.

Now that we install a new enough gettext-base, we can finally do this
and remove the initialization hacks.

Will-fix: #9371

I.e. also the Unsafe and I2P Browser's. The main reason is so we do
not need different images for these and the Tor browser in the
automated test suite. One may argue, though, that for the Unsafe
Browser this list of fonts would be fingerprintable, but I would be
surprised if it already isn't so due to the Tor Browser Firefox
patches.

The Tor Browser assumes that the working directory is the directory
where the browser lives (e.g. the executable). For instance, the
fonts.conf (for fontconfig) the Tor Browser uses looks for the fonts
in the "fonts" sub-directory of the current working directory. This
will fix issues with "empty boxes" as characters in the Save As/Open
dialoges.

Will-fix: #11097

E.g. for our custom/undocumented (but so far unused)
`--force-net-config` option.

The path hasn't existed for a long while, and places.sqlite hasn't
been created there for even longer.

... instead of polluting the complete environment with it.

It feels like it belongs better in the script where we actually start
Tor Launcher than the wrapper that makes root invoke it in the way we
want. Also, we have to think less about how sudo propagates
environment variables so we can simplify its setup.

To simplify some paths.

... where we have the Tor Browser. For consistency.

Let's not pretend the current script is similar to what upstream would
use, since it has Tails specific stuff in it.

... instead of the crazy workaround we had to use before. It turns out
you *can* use -app and -profile together, but only if -profile is
given last. It may be that it was fixed recently, because I'm pretty
sure it didn't work last time I wroked on this.

Also, in /usr/share/TorBrowser/Data/Browser (which is the "default"
profile directory relative to the Tor Launcher applocation.ini file)
the Caches directory must exist and be accessible for the tor-launcher
user even if -profile is used, so we just have to ensure it exists.

Will-fix: #7943

Sadly this was missed so we won't have it in Tails 2.0.

Fix-committed: #11000

This is what we do everywhere else in our code base.

refs: #10684

refs: #9012

This might help cure refs: #9012. It should not slow down the login process as
long as we run tails-unblock-network in the background from PostLogin.

Will-fix: #10785

file.

Otherwise people will get the notification every time they start Icedove
during the 1.8 lifetime.

Will-fix: #10458

Refs: #10458

Will-fix: 10167

`systemctl daemon-reload' is a very big hammer: while it's running, socket
activation, D-Bus activation, and more systemd functionality are disabled.
In this case, as long as we use only systemctl {stop, disable, mask}, then we
don't need to do a global daemon reload, so let's not take the risk.

Earlier we already ensure that Tor has bootstrapped, which implies
that the control port must be up.

Otherwise Vidalia will be running and showing errors while we make
sure that Tor bootstraps, which could take a while.

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Now that it's in lib/, it's not going to be chmod'ed via auto/build.

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658

Refs: #10658