GitLab

Will-Fix: #10112

The old one doesn't apply on top of testing's torbrowser-launcher anymore.
Our Jenkins job didn't warn us in advance because the changes made in Debian
were made with quilt patches, and that job only tests Git merging.

The new (ESR38) search bar only shows icons, which is problematic when
we want to include several locales of some search engine at the same
time, like Wikipedia (we want to include English in non-English
locales). Now we also generate localized Wikipedia search engine
plugin icons, which has an indicator of which language is used (by
language code) which should mitigate this.

Will-fix: #9955

Fix-committed: #7525

Refs: #7525

By default, it uses /tmp/, but we want to deny it access to there.

Will-fix: #9558

Will-fix: #9558

In the past, we had "exit 1" in there. This problem was identified (#8571) and
fixed (commit 1b46b5b1) in Tails 1.2.3, by replacing this "exit 1"
with "return 1".

Then, while working on another, minor problem (#8687), the "exit 1" was
reintroduced (commit 4ea050ab) in Tails 1.3.2, presumably because we pasted
sample code from the ticket, that had been drafted *before* #8571 was fixed.
Sadly, nobody noticed in time.

I cannot easily reproduce the bug on Tails/Wheezy (because I lack hardware whose
MAC address fails to be spoofed there), but I could reproduce it with
Tails/Jessie ("thanks" to the fact we're currently shipping the buggy 'wl'
kernel module in there).

Will-Fix: #9531

I.e. hide the same things we hide in the Tor Browser. These features
wouldn't work in the I2P Browser, and would encourage unsupported
usage of the Unsafe Browser.

It shouldn't be able to fetch those URLs, but it shouldn't even try.

With this pref enabled (which is the default) e.g. US locales will use
the browser.search.*.US prefs, which just complicates things.

The sha256sums.txt hasn't been signed yet so it has only been verified
by downloading it through HTTPS. This should be cool since this is for
testing purposes only.

Will-fix: #9126

This reverts commit baf42e04.

If such access is denied, then Tor Browser plays sound directly
with Alsa, which makes UX worse... and breaks our automated tests.

It was initially added because it was needed for Tor Browser to play sound with
PulseAudio, but in the end it turns out that this use case works just fine
without allowing such access => let's tighten thing a bit, and make our delta
with upstream's profile smaller.

Note that machine-id is currently a per-Tails-version identifier, but depending
on the outcome of #7100 it may become a per-Tails-boot one.

torbrowser-AppArmor-profile.patch: refresh to apply cleanly on top of the profile shipped with torbrowser-launcher 0.2.0-1.

The patch is modified because upstream has taken a change that was previously
part of our delta, and that I had submitted to them.

Not only this directory needlessly takes room in ISO images, but it also makes
IUKs bigger than they could be: there are time-based variations in there.

Will-fix: #9417

Will-fix: #9369

Until recently it defaulted to Start Page purely by chance. While we
could pick Start Page now, Google seems like a less suspicious choice.

Previously these parts have been spread out in several, heavily
coupled hooks and static configurations, making it very hard to get an
overview of how it all actually works. Now we instead do everything in
one place, and generate things programatically as much as possible,
which makes supporting another locale much simpler (just adding a
single line with a few pieces of needed info!). Consequently this
commit also adds better localization for every locale supported by the
Tor Browser (added: ar, es, fa, ko, nl, pl, ru, tr, vi and zh_CN)
instead of the euro-centric (w.r.t. actually adding localization) ones
we had picked before. Also, we'll get build level errors for many
types of errors, so they're caugt early.

This commit may seem like a gigantic, non-atomic beast, but splitting
it would be hard, and it actually mostly removes stuff. Its design is
simple: We have a description file that, for each supported Tor
Browser locale, has the extra pieces of info needed, like the
localized name of the language, the parameters needed for certain
search engines etc. Then we apply them to:

* a templates for the amnesia branding locale file, and put in the
  relevant values there so the default search engine is selected, the
  correct spellchecker (if installed) is pre-selected, and our
  homepage is localized (if supported).

* a template for each of the search engines we want to localize
  (currently Start Page and Disconnect.me -- we could do Google but
  most (all?) locales get a localized one from the Iceweasel
  localization packages) and generate localized ones.

Also, following the Tor Browser's recent switch, we now use
Disconnect.me as the default search engine, although we localize it
for each supported locale.

Will-fix: #9309

We use / as sed separator, so we need to escape any occurrences of it
in the key or value, so we can e.g. can set paths or urls.

This will be useful soon.

Together with `set -e` that error has prevented this script from
restarting Vidalia, like it should.

Will-fix: #9328

It can still be accessed through about:addons, but it's currently
broken (#9307). Also, we do not want users to install add-ons in the
Unsafe Browser (it's outside of the indended use cases, and it may get
weird since restarting it will clear the chroot => all extensions are
lost -- add to this that some extensions only work well after
restarting the browser), so let's just hide it.

(This change is borrowed from the equivalent change in the I2P Browser
in commit b504ba67.)

Will-fix: #9305

Due to a recent change, perhaps in Java, `netstat -4nlp` no longer shows
the I2P ports. Changing the parameters to `-nlp` will resolve this problem.

Will-fix: #9324

We haven't sourced the Tails shell library's loggin module, so log()
is undefined. Since we `rm -f` the file, log():ing if it still exists
afterwards *should* be pointless, so let's just not do it all.

... cause the control port language doesn't care about it.

(We could have skipped the whole business of using regexes and just
upper():ed the `line` variable and then do a normal string comparison,
but that would also upper() any arguments. It doesn't matter now since
we only care about commands, but if we ever extend this filter so that
arguments do matter, we won't get shot by potentially missing that.)

By checking that the command is ended with a word boundary.

Our installation script determines the Tor Browser version from the
tarball filenames and then looks in "$(cat
tbb-dist-url.txt)/$VERSION", which isn't very flexible. For instance,
for the pre-release of Tor Browser 4.5 our script looks in:

    http://people.torproject.org/~mikeperry/builds/4.5/

when they in fact were stored in

    http://people.torproject.org/~mikeperry/builds/4.5-build5/

So let's just store the full URL to the directory storing the
tarballs.