While messing with @torbrowser probably works here, it feels
wrong.

In particular this enables the retry magic we added for the "Tails
documentation" launcher to the "Report and Error" case since the code
now is refactored and used in all cases.

This step can also start the Tor Browser, so it must initialize the
'@torbrowser' variable.

This is vs #12059, which changes the semantics of Dogtail so that
nodes are searched for on Dogtail::* object creation.

Refs: #12059

This reverts commit 75449088.

I need the test suite working to release 3.0~beta2, and it's been quite broken
on feature/stretch since the merge of test/12059-dogtail-optimizations.

refs: #12305

We have decided to remove I2P (Refs: #11276) due to our failure of
finding someone interested in maintaining it in Tails.

Will-fix: #12263

Soon I'll use it in the German locale, where the image won't match.

This reverts commit f7594f97.

This causes more issues than it solves. And I should say "potentially
solves", cause now I am unsure if the reverted commit was sound. My
motivation for it was rational, not empirical, and that seems to be a
bad approach with the test suite. :)

Refs: #11464

Sometimes it just seems to take longer for it to show up.

Whoops!

Beside the image bumping due to the new font we use in Stretch, we
also take steps making Tor bootstrap more reliable in the upgraded
system. It used to be unreliable because the IUK sets a very wrong
release date, and we use it in our time syncing.

Normally we run these steps in this order:

    When Tor is ready
    And all notifications have disappeared

but the second step may run *before* the 'Tor is ready' notification
is shown, so it's not closed. It has been observed to block important
parts of the GNOME Activities Overview, leading to failure when trying
to start applications.

Refs: #12066

Fix-committed: #11464

We don't use it for switching between applications, only for starting
new ones, so if we use it for an application that is already running
we want a new instance.

And readable, imho. I think (x)? is better than (|x), and the
resulting value makes for prettier usage in conditions (positive
instead of negative).

We won't have it in Tails 3.0~beta1 since the Greeter doesn't have
that option, and it's not even sure we'll reintroduce it since it's
apparently quite buggy and not widely used.

Will-fix: #12055
Refs: #12093

We set it by default, but it doesn't seem to take effect. This could
be due to a bug in our Dogtail patch which added that feature.

TailsBootSplash.png was removed a while ago. And TailsGreeter.png will
check further that Tails booted, which is nice.

In robust_notification_wait() when we close the notification applet,
other windows may change position, creating a racy situation for any
immediately following action aimed at one such window.

Refs: #10381

I.e. when we get a kernel stack trace instead of a BusyBox shell.

Refs: #11786

This should be reverted once #11786 is fixed properly.

This commit is a backport from the tails/stretch of the two
workarounds we implemented there.

Refs: #10776, #11786

Refs: #12134

This reverts commit 925ea0d9.

Commit 07dfb622 invalidated this
sanity check.

This reverts the revert commits d264dbf1
and e97dc693.

Even though the GNOME Shell extension's logic to avoid double-starting Florence
is flawed, it is only flawed when one 0. uses Florence; 1. uses a system where
Florence needs more than 1 second to start; and 2. one waits more than 1 second,
but less than the time it takes to start before clicking on the icon again.

The alternate option this commit reverts has worse problems: Florence sometimes
is not hidden on startup, which affects all users, and requires an ugly
workaround in the test suite (which is broken on feature/stretch currently, so
this comes with a maintenance cost). Besides, it eats memory for everybody,
while I expect the vast majority of users don't actually use Florence.

So, all in all, I prefer going back to the behaviour previously implemented
in feature/stretch, that I had reverted earlier today.

Revert "Test suite: drop obsolete workaround for Florence sometimes not being hidden on startup (#11398)."

This reverts commit 7478982c.

We start it automatically again.

This reverts commit 851f3e7a.

This reverts commit 40332999.

Due to #12061, we typically wait about 90 seconds before we start wiping the
memory, so let's factor this in as an additional constant, instead of as
a multiplication factor.

Test suite: start adjusting for the way additional settings are handled in the new Greeter (refs: #12055).

Apparently 1 MiB isn't enough for the overhead when sharing the Tails
ISO image.