GitLab

I see that this is not super obvious, but KeyboardSettingUI.apply()
assumes that the keyboard setting was changed by the user, so it sets
IS_DEFAULT (which is somewhat misnamed, it should rather be
WAS_SET_AUTOMATICALLY (or WAS_SET_BY_USER, with the opposite value))
to false.

When the keyboard layout is changed automatically because the language
was changed, we want to set IS_DEFAULT to true, so we don't call
KeyboardSettingUI.apply(), but directly self._setting.save().

What was missing was the call to apply_layout_to_current_screen(), which
was causing #17794.

the previous behaviour was confusing: changing the language was
changing the keyboard layout in the UI, but not really changing it.

As tails-spoof-mac is running as root, its messages cannot be translated
according to the user settings. This commit solves this problem by reading the
localization settings from the environment (/etc/default/locale) in
tails-spoof-mac initialization. To make this work, we also set up the desired
localization environment before launching tails-unblock-network and
tails-spoof-mac.

On MAC spoofing failure, include the name of the disabled network card in the title of the notification

That was the intention since 988b4186
but in that commit, we forgot to replace gettext with eval_gettext
when introducing variables in the translatable string. Let's fix this
and accordingly, drop the test suite workaround for this bug.

refs: #17784

This will ease my review of !70 and future work on the panic mode
code paths.

refs #17786, #17323

refs: #17786

refs #17786

Delegate the discover of interface names to udev, instead of relying
on reading and parsing /sys and lspci ourself, to make the discover
more resilient to missing files, bus agnostic (allowing to discover
non PCI devices like USB ones), and explicit (using udev's own hwdb).

Fixes regression introduced in 5ca08252.

Suggested-by: ShellCheck
Documentation: https://www.shellcheck.net/wiki/SC2148

Suggested-by: ShellCheck
Documentation: https://www.shellcheck.net/wiki/SC2145

Suggested-by: ShellCheck
Documentation: https://www.shellcheck.net/wiki/SC2045

Suggested-by: ShellCheck
Documentation: https://www.shellcheck.net/wiki/SC2068

2c3b9827 added a preset but this test suite
was not updated accordingly.

this takes in consideration the case of revision or other message that
might follow the device code.
I don't have HW that has revisions, so I don't know if they are put
before or after the device code.

The code is now defensive on this: the device code is extracted as the
last block which might look like a device code, and the rest is kept as
device name.

the codes are put at the left: this makes it less probable that they are
trimmed away.

filtering with -d::0300 is enough

just run with "doctest" on the cmdline

a message which is easier to read is more likely to give useful bug reports

plymouth has stringent limits on message-length. The previous method of trimming the message
was only appropriate for single-line messages. Now it's always valid.

This is important because messages exceeding length would result in no message at all.

refs: #6156

refs: #17808