Commit b6a409fe authored by intrigeri's avatar intrigeri
Browse files

Test suite: wait for the Stop button to vanish after stopping page loading.

Since commit:26d902fe we've been using code
proposed on https://labs.riseup.net/code/issues/10116#note-14 that does not make
any sense to me: after pressing Escape, what matters is that the Stop button
vanishes, i.e. the page has stopped loading, and not the Reload button.
Unless I'm very confused and did not get the reasoning behind that code.

Spotted by segfault!
parent 85392012
......@@ -89,7 +89,7 @@ When /^I open the address "([^"]*)" in the (.*)$/ do |address, browser|
end
recovery_on_failure = Proc.new do
@screen.type(Sikuli::Key.ESC)
@screen.waitVanish(info[:browser_reload_button_image], 3)
@screen.waitVanish(info[:browser_stop_button_image], 3)
open_address.call
end
if browser == "Tor Browser"
......@@ -227,7 +227,7 @@ Then /^I can listen to an Ogg audio track in Tor Browser$/ do
end
recovery_on_failure = Proc.new do
@screen.type(Sikuli::Key.ESC)
@screen.waitVanish(info[:browser_reload_button_image], 3)
@screen.waitVanish(info[:browser_stop_button_image], 3)
open_test_url.call
end
step "no application is playing audio"
......@@ -245,7 +245,7 @@ Then /^I can watch a WebM video in Tor Browser$/ do
end
recovery_on_failure = Proc.new do
@screen.type(Sikuli::Key.ESC)
@screen.waitVanish(info[:browser_reload_button_image], 3)
@screen.waitVanish(info[:browser_stop_button_image], 3)
open_test_url.call
end
open_test_url.call
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment