Merge remote-tracking branch 'origin/test/9491-debug-cucumber-formatter' into stable

Fix-committed: #9491

features/step_definitions/common_steps.rb

@@ -110,7 +110,7 @@ end
 
 Then /^drive "([^"]+)" is detected by Tails$/ do |name|
   next if @skip_steps_while_restoring_background
-  raise "Tails is not running" if @vm.is_running?
+  raise "Tails is not running" unless @vm.is_running?
   try_for(10, :msg => "Drive '#{name}' is not detected by Tails") do
     @vm.disk_detected?(name)
   end

run_test_suite

@@ -172,7 +172,6 @@ CAPTURE_FILE=
 LOG_FILE=
 VNC_VIEWER=
 VNC_SERVER=
-DEBUG=
 PAUSE_ON_FAIL=
 KEEP_SNAPSHOTS=
 SIKULI_RETRY_FINDFAILED=

wiki/src/contribute/release_process/test/usage.mdwn

@@ -32,6 +32,17 @@ feature, we'd simply run something like:
 
     ./run_test_suite features/build.feature
 
+Actually, `run_test_suite` is just a wrapper around `cucumber`, so any
+`cucumber` option can be passed too, although after an `--` so they
+are not confused with the wrapper's options. For instance:
+
+    ./run_test_suite ... -- --format debug features/apt.feature
+
+will enable the `debug` formatter, which in Tails' Cucumber setup will
+enable debugging information to be printed (which is *very* useful
+when debugging or developing for the test suite) unlike in vanilla
+Cucumber, where it's used for debugging the formatting subsystem.
+
 For full instructions, see its `--help`.
 
 Note: since the test suite itself uses `virt-viewer` to interact with
@@ -72,9 +83,6 @@ can be use by concurrent test suite runs):
 Here's a list of all non-secret key-value pairs that can be supported
 by the local configuration file:
 
-* `DEBUG`: Boolean value. If set to `true`, various debugging info
-  will be printed. Defaults to `false`.
-
 * `MAX_NEW_TOR_CIRCUIT_RETRIES`: Integer. Upon failure, some test steps may be
   run again after requesting that connections are made using new Tor circuits. This
   configuration variable limits how many times forcing a circuit will be