Test suite: drop usage and tests of read-only persistence.

We won't have it in Tails 3.0~beta1 since the Greeter doesn't have
that option, and it's not even sure we'll reintroduce it since it's
apparently quite buggy and not widely used.

Will-fix: #12055
Refs: #12093

features/persistence.feature

@@ -17,10 +17,10 @@ Feature: Tails persistence
     And all persistent directories have safe access rights
     When I disable the first persistence preset
     And I shutdown Tails and wait for the computer to power off
-    And I start Tails from USB drive "__internal" with network unplugged and I login with read-only persistence enabled
+    And I start Tails from USB drive "__internal" with network unplugged and I login with persistence enabled
     Then all persistence presets but the first one are enabled
 
-  Scenario: Writing files first to a read/write-enabled persistent partition, and then to a read-only-enabled persistent partition
+  Scenario: Writing files first to a read/write-enabled persistent partition
     Given I have started Tails without network from a USB drive with a persistent partition enabled and logged in
     And the network is plugged
     And Tor is ready
@@ -29,19 +29,6 @@ Feature: Tails persistence
     And I shutdown Tails and wait for the computer to power off
     # XXX: The next step succeeds (and the --debug output confirms that it's actually looking for the files) but will fail in a subsequent scenario restoring the same snapshot. This exactly what we want, but why does it work? What is guestfs's behaviour when qcow2 internal snapshots are involved?
     Then only the expected files are present on the persistence partition on USB drive "__internal"
-    Given I start Tails from USB drive "__internal" with network unplugged and I login with read-only persistence enabled
-    And I capture all network traffic
-    And the network is plugged
-    And Tor is ready
-    Then Tails is running from USB drive "__internal"
-    And the boot device has safe access rights
-    And all persistence presets are enabled
-    And there is no GNOME bookmark for the persistent Tor Browser directory
-    And I write some files not expected to persist
-    And I remove some files expected to persist
-    And I take note of which persistence presets are available
-    And I shutdown Tails and wait for the computer to power off
-    Then only the expected files are present on the persistence partition on USB drive "__internal"
 
   Scenario: Creating and using a persistent NetworkManager connection
     Given I have started Tails without network from a USB drive with a persistent partition enabled and logged in
@@ -49,7 +36,7 @@ Feature: Tails persistence
     And Tor is ready
     And I add a current wired DHCP NetworkManager connection called "persistent-con-current"
     And I shutdown Tails and wait for the computer to power off
-    Given I start Tails from USB drive "__internal" with network unplugged and I login with read-only persistence enabled
+    Given I start Tails from USB drive "__internal" with network unplugged and I login with persistence enabled
     And I capture all network traffic
     And the network is plugged
     And Tor is ready
@@ -63,7 +50,7 @@ Feature: Tails persistence
     And Tor is ready
     And I add a 2.x wired DHCP NetworkManager connection called "persistent-con-2.x"
     And I shutdown Tails and wait for the computer to power off
-    Given I start Tails from USB drive "__internal" with network unplugged and I login with read-only persistence enabled
+    Given I start Tails from USB drive "__internal" with network unplugged and I login with persistence enabled
     And I capture all network traffic
     And the network is plugged
     And Tor is ready

features/step_definitions/common_steps.rb

@@ -143,7 +143,7 @@ Given /^I start Tails( from DVD)?( with network unplugged)?( and I login)?$/ do
   end
 end
 
-Given /^I start Tails from (.+?) drive "(.+?)"(| with network unplugged)( and I login(| with(| read-only) persistence enabled))?$/ do |drive_type, drive_name, network_unplugged, do_login, persistence_on, persistence_ro|
+Given /^I start Tails from (.+?) drive "(.+?)"(| with network unplugged)( and I login(| with persistence enabled))?$/ do |drive_type, drive_name, network_unplugged, do_login, persistence_on|
   step "the computer is set to boot from #{drive_type} drive \"#{drive_name}\""
   if network_unplugged.empty?
     step "the network is plugged"
@@ -153,13 +153,7 @@ Given /^I start Tails from (.+?) drive "(.+?)"(| with network unplugged)( and I
   step "I start the computer"
   step "the computer boots Tails"
   if do_login
-    if ! persistence_on.empty?
-      if persistence_ro.empty?
-        step "I enable persistence"
-      else
-        step "I enable read-only persistence"
-      end
-    end
+    step "I enable persistence" if persistence_on
     step "I log in to a new session"
     if network_unplugged.empty?
       step "Tor is ready"

features/step_definitions/usb.rb

@@ -379,11 +379,6 @@ Given /^persistence is disabled$/ do
   assert(!tails_persistence_enabled?, "Persistence is enabled")
 end
 
-Given /^I enable read-only persistence$/ do
-  step "I enable persistence"
-  @screen.wait_and_click('TailsGreeterPersistenceReadOnly.png', 10)
-end
-
 def boot_device
   # Approach borrowed from
   # config/chroot_local_includes/lib/live/config/998-permissions

features/torified_browsing.feature

@@ -162,7 +162,7 @@ Feature: Browsing the web using the Tor Browser
     And I add a bookmark to eff.org in the Tor Browser
     And I warm reboot the computer
     And the computer reboots Tails
-    And I enable read-only persistence
+    And I enable persistence
     And I log in to a new session
     And I start the Tor Browser in offline mode
     Then the Tor Browser has a bookmark to eff.org