Commit 83974621 authored by Sandro Knauß's avatar Sandro Knauß

Allow trival changes from the reivewer to save roundtrips.

parent 1301efea
......@@ -24,6 +24,9 @@
maintenance includes: polishing the proposed changes to make them fit
for release; writing and updating the design and end-user
documentations; fixing bugs.
- As reviewer, you are allowed to to trival checks e.g. {typos in,phrasing of}
comments and string on top of the proposed patch to avoid rountrips.
You need to report back those changes.
- Remember that it's hard to receive negative feedback. Don't forget
to note the good parts, be constructive and precise in your
comments, and never use reviews to make personal attacks. You can
......
......@@ -5,7 +5,7 @@ be named `feature/XXX`. For a bugfix about YYY, it should be named
`bugfix/YYY`. Ideally, include the relevant ticket number in the topic
branch name, e.g. `bugfix/7173-upgrade-syslinux`.
When the developer thinks it is good enough and has tested it, she must:
When you think it is good enough and has tested it, you have to:
- Set the ticket's *Status* field to *In Progress* (if you do not see
this field when editing the ticket, ask the [[sysadmin team|contribute/working_together/roles/sysadmins]]
......@@ -17,10 +17,10 @@ When the developer thinks it is good enough and has tested it, she must:
this means, you do not) please make sure that your branch has not
broken any tests! Or, if you only want a first review of your code,
without bothering with the build & test status on Jenkins, that's fine:
make it clear to the reviewer that it's what you expect and that
your branch is not ready to merge.
make it clear to the reviewer what you expect and
that your branch is not ready to merge.
- Set the ticket's *QA Check* field to *Ready for QA*.
- Assign this ticket to nobody (aka. unassign it from yourself) by
- Assign the ticket to nobody (aka. unassign it from yourself) by
default. Unless it's clear to you that nobody on the
[[Foundations Team|working_together/roles/foundations_team]] will be
able or willing to do this specific review; in that case, _you_ shall try
......@@ -36,4 +36,7 @@ merging, they should set the ticket's *QA Check* field back to *Needs
more dev* or *Needs more info* state, and
from now on it's the responsibility of the branch/ticket "holder" to
change it back to *Ready for QA* once they consider the issues raised by
the reviewer are fixed.
the reviewer are fixed. The reviewer is allowed to add trivial changes,
e.g. {typos in,phrasing of} comments and string on top of the proposed patch
to avoid roundtrips. But the reviewer needs to communicate those changes to
the branch/ticket "holder".
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment