Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
7
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
tails
tails
Commits
6df20e29
Commit
6df20e29
authored
Apr 03, 2019
by
intrigeri
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix typos and grammar mistakes.
parent
83974621
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
5 deletions
+5
-5
wiki/src/contribute/merge_policy/review.mdwn
wiki/src/contribute/merge_policy/review.mdwn
+2
-2
wiki/src/contribute/merge_policy/submit.mdwn
wiki/src/contribute/merge_policy/submit.mdwn
+3
-3
No files found.
wiki/src/contribute/merge_policy/review.mdwn
View file @
6df20e29
...
...
@@ -24,8 +24,8 @@
maintenance includes: polishing the proposed changes to make them fit
for release; writing and updating the design and end-user
documentations; fixing bugs.
- As reviewer, you are allowed to t
o
trival
check
s e.g. {typos in,phrasing of}
comments and string on top of the proposed patch to avoid rountrips.
- As reviewer, you are allowed to
commi
t triv
i
al
fixe
s e.g. {typos in,phrasing of}
comments and string
s
on top of the proposed patch to avoid roun
d-
trips.
You need to report back those changes.
- Remember that it's hard to receive negative feedback. Don't forget
to note the good parts, be constructive and precise in your
...
...
wiki/src/contribute/merge_policy/submit.mdwn
View file @
6df20e29
...
...
@@ -5,7 +5,7 @@ be named `feature/XXX`. For a bugfix about YYY, it should be named
`bugfix/YYY`. Ideally, include the relevant ticket number in the topic
branch name, e.g. `bugfix/7173-upgrade-syslinux`.
When you think it is good enough and ha
s
tested it, you have to:
When you think it is good enough and ha
ve
tested it, you have to:
- Set the ticket's *Status* field to *In Progress* (if you do not see
this field when editing the ticket, ask the [[sysadmin team|contribute/working_together/roles/sysadmins]]
...
...
@@ -37,6 +37,6 @@ more dev* or *Needs more info* state, and
from now on it's the responsibility of the branch/ticket "holder" to
change it back to *Ready for QA* once they consider the issues raised by
the reviewer are fixed. The reviewer is allowed to add trivial changes,
e.g. {typos in,phrasing of} comments and string on top of the proposed patch
to avoid roundtrips. But the reviewer needs to communicate those changes to
e.g. {typos in,phrasing of} comments and string
s
on top of the proposed patch
to avoid round
-
trips. But the reviewer needs to communicate those changes to
the branch/ticket "holder".
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment