Commit 66b8e6bf authored by anonym's avatar anonym
Browse files

Make tor-controlport-filter reusable.

I.e. make it possible to pass the listen port, and Tor control
cookie/socket paths as arguments.

Will-fix: #6742
parent ac7c9d8f
......@@ -9,6 +9,7 @@
# which are pretty self-explanatory as long as you understand the Tor
# ControlPort language.
import argparse
import glob
import psutil
import re
......@@ -17,6 +18,16 @@ import stem
import stem.control
import yaml
DEFAULT_COOKIE_PATH = '/var/run/tor/control.authcookie'
DEFAULT_CONTROL_SOCKET_PATH = '/var/run/tor/control'
# This will store the arguments from argparse. We put it in the global
# scope since it's awkward to extend socketserver so additional data
# can be sent to the request handler, where we need access to the
# arguments.
global_args = None
# Limit the length of a line, to prevent DoS attacks trying to
# crash this filter proxy by sending infinitely long lines.
......@@ -128,11 +139,11 @@ class FilteredControlPortProxyHandler(socketserver.StreamRequestHandler):
def connect_to_real_control_port(self):
# Read authentication cookie
with open("/var/run/tor/control.authcookie", "rb") as f:
with open(global_args.control_cookie_path, "rb") as f:
cookie =
# Connect to the real control port
controller = stem.control.Controller.from_socket_file("/var/run/tor/control")
controller = stem.control.Controller.from_socket_file(global_args.control_socket_path)
except stem.SocketError:
......@@ -154,10 +165,30 @@ class FilteredControlPortProxyHandler(socketserver.StreamRequestHandler):
def main():
listen_port = 9052
server = socketserver.ThreadingTCPServer(("localhost", listen_port),
print("Tor control port filter started, listening on %d" % listen_port)
parser = argparse.ArgumentParser()
"-p", "--listen-port",
type = int, metavar = 'PORT', default = DEFAULT_LISTEN_PORT,
help = "specifies the port on which the server listens " +
"(default: {})".format(DEFAULT_LISTEN_PORT))
"-c", "--control-cookie-path",
type = str, metavar = 'PATH', default = DEFAULT_COOKIE_PATH,
help = "specifies the path to Tor's control authentication cookie " +
"(default: {})".format(DEFAULT_COOKIE_PATH))
"-s", "--control-socket-path",
type = str, metavar = 'PATH', default = DEFAULT_CONTROL_SOCKET_PATH,
help = "specifies the path to Tor's control socket " +
"(default: {})".format(DEFAULT_CONTROL_SOCKET_PATH))
global global_args
global_args = parser.parse_args()
server = socketserver.ThreadingTCPServer(
("localhost", global_args.listen_port),
print("Tor control port filter started, listening on {}"
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment