Commit 3eeefec6 authored by intrigeri's avatar intrigeri

Improve phrasing.

parent 6df20e29
......@@ -24,9 +24,10 @@
maintenance includes: polishing the proposed changes to make them fit
for release; writing and updating the design and end-user
documentations; fixing bugs.
- As reviewer, you are allowed to commit trivial fixes e.g. {typos in,phrasing of}
comments and strings on top of the proposed patch to avoid round-trips.
You need to report back those changes.
- As reviewer, you are allowed to commit trivial fixes on top of the
proposed branch to avoid round-trips: for example, fixing typos
and improving phrasing of comments and strings.
Then, report back about these changes on the ticket.
- Remember that it's hard to receive negative feedback. Don't forget
to note the good parts, be constructive and precise in your
comments, and never use reviews to make personal attacks. You can
......
......@@ -36,7 +36,9 @@ merging, they should set the ticket's *QA Check* field back to *Needs
more dev* or *Needs more info* state, and
from now on it's the responsibility of the branch/ticket "holder" to
change it back to *Ready for QA* once they consider the issues raised by
the reviewer are fixed. The reviewer is allowed to add trivial changes,
e.g. {typos in,phrasing of} comments and strings on top of the proposed patch
to avoid round-trips. But the reviewer needs to communicate those changes to
the branch/ticket "holder".
the reviewer are fixed.
The reviewer is allowed to commit trivial fixes on top of the
proposed branch to avoid round-trips: for example, fixing typos
and improving phrasing of comments and strings. They must
report back about these changes on the ticket.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment