1. 17 Nov, 2020 1 commit
  2. 27 Oct, 2020 1 commit
  3. 09 Jul, 2020 1 commit
  4. 01 Jun, 2020 1 commit
  5. 26 May, 2020 1 commit
  6. 19 May, 2020 3 commits
  7. 14 May, 2020 2 commits
  8. 13 May, 2020 4 commits
  9. 11 May, 2020 5 commits
  10. 10 May, 2020 2 commits
    • intrigeri's avatar
      Test suite: review and adjust every blind rescue · 36d0aa8b
      intrigeri authored
      As per https://rubystyle.guide/#too-many-params, rescuing the Exception
      class traps signals. We do this quite a bit, which might explain
      why a simple CTRL-c is often not sufficient to kill the test suite.
      
      So:
      
       - In most cases, our exception handling code does not feel safe enough when
         we're facing a ctrl-c or another system-level exception (think ENOSPAC), i.e.
         we can't be sure it'll manage to rethrow the exception, I've replaced
         "rescue Exception" with "rescue StandardError".
      
       - In a few cases, the exception handling code was really specific to a given
         "raise" we wrote ourselves, and we're using exceptions raising/rescuing as
         our own control flow mechanism (test fails ⇒ raise), so I'm switching to
         dedicated exception classes in order to rescue only what we want, and no
         other unexpected Exception.
      
       - In some cases, we have fine-grained custom exception handling, including
         comments about "all other exceptions", so to make things extra clear I'm
         rescuing Exception separately from StandardError in those cases; this should
         highlight the different intended behaviors.
      
      Note that at first glance, the exception handling code that runs
      destroy_and_undefine looks useful even when aborting with SIGTERM.
      Thankfully, our at_exit handler runs it too, so there's no need
      to _also_ run it in the exception handlers.
      
      Finally, enable the Lint/RescueException Rubocop check: once we run Rubocop as
      part of our CI, this should avoid us (possibly me!) typing "rescue Exception"
      without being fully conscious of what it really catches.
      36d0aa8b
    • intrigeri's avatar
  11. 24 Apr, 2020 1 commit
  12. 23 Apr, 2020 6 commits
  13. 22 Apr, 2020 8 commits
  14. 21 Apr, 2020 4 commits