1. 17 Nov, 2020 1 commit
  2. 12 Nov, 2020 1 commit
    • anonym's avatar
      Test suite: make local.yml load before *.d dirs, as intended. · 7bceca0a
      anonym authored
      The documentation says it should be so, and it makes sense: currently
      I have our shared-secrets.d in there, but I need to override the
      Thunderbird parts since I'm not running on Jenkins, and local.yml is
      the right place for that.
      7bceca0a
  3. 02 Nov, 2020 2 commits
    • anonym's avatar
      Test suite: login using the button, not accelerators. · 7b1e2567
      anonym authored
      This allows us to drop the start_accel column in the scenario outline,
      which is nice to not have to maintain.
      7b1e2567
    • anonym's avatar
      Test suite: implement find_any() with real_find(). · d186e198
      anonym authored
      We recently bumped the timeout in find() from 2 to 5 seconds (in !218
      for #17985) which made me notice that it's not very appropriate to
      call find() in find_any() and related functions since that timeout
      makes us block very long on each image before moving on to the next.
      
      I saw an instance where we use find_any() on five images with a 20
      second timeout. This makes it impossible to match the fifth image
      since we'll spend 4*5 = 20 seconds on the first four images and thus
      timeout before we even try the fifth. Ouch!
      d186e198
  4. 28 Oct, 2020 1 commit
    • intrigeri's avatar
      Test suite: don't let Screen#find mess with Screen#wait_vanish's timeout argument · d369bb1c
      intrigeri authored
      7fe21236, and later
      d019aa38, by adding an implicit waiting delay in
      Screen#find, made the semantics of the timeout of Screen#wait_vanish buggy: if
      that timeout is too small compared to the duration of that implicit waiting
      delay, then the timeout of the try_for loop in Screen#wait_vanish will expire
      without having actually tried enough times, effectively making the timeout
      passed to wait_vanish moot.
      
      For example, at d019aa38,
      this step:
      
        I do not see "TorBrowserSynapticManual.png" after at most 5 seconds
      
      … often fails, because Screen#wait is called only once, very early,
      and at that time TorBrowserSynapticManual.png is still on the screen.
      That image disappears quickly, but given the 2 timeouts have the same value
      (5 seconds), we don't even try a second time.
      
      So let's bypass Screen#find in Screen#wait_vanish, and instead call
      Screen#wait directly with timeout=0.
      d369bb1c
  5. 27 Oct, 2020 2 commits
  6. 26 Oct, 2020 1 commit
  7. 15 Oct, 2020 1 commit
  8. 19 Sep, 2020 1 commit
  9. 18 Sep, 2020 9 commits
  10. 04 Sep, 2020 1 commit
  11. 02 Sep, 2020 1 commit
  12. 09 Jul, 2020 1 commit
  13. 25 Jun, 2020 1 commit
  14. 01 Jun, 2020 1 commit
  15. 26 May, 2020 1 commit
  16. 19 May, 2020 4 commits
  17. 14 May, 2020 2 commits
  18. 13 May, 2020 4 commits
  19. 12 May, 2020 2 commits
    • intrigeri's avatar
      Test suite: fix regression on Stretch introduced earlier on this branch · 83a6c49b
      intrigeri authored
      Fixup against 4efe5283.
      
      Interestingly, I did not have this problem with Ruby 2.7.1 on my system,
      but on Jenkins (Ruby 2.3.3) I see this error:
      
        wrong argument type String (expected Symbol) (TypeError)
        ./features/step_definitions/pidgin.rb:113:in `/^my XMPP friend goes online( and joins the multi-user chat)?$/'
      
      Until we require Buster for running our test suite, the current implementation
      is rather ugly, but I figured it's better to have an ugly backwards
      compatibility workaround than to stick with old arguments passing style: it
      brings us one step closer to Ruby best practices.
      83a6c49b
    • intrigeri's avatar
      Test suite: add an option to keep Chutney data, but no snapshots, between runs · 5394aba2
      intrigeri authored
      With an already-bootstrapped data directory, Chutney bootstraps in seconds,
      while that takes a few minutes when boostrapping from scratch.
      
      I've found myself having to debug test steps that lead to snapshots, so I could
      not use --keep-snapshots. And then, the duration of my feedback loop was hugely
      dominated by Chutney bootstrapping from scratch. After locally hacking
      ensure_chutney_is_running for a while to work around this, to make it short
      circuits, since the tests I was working on don't even use Tor, I figured it
      would be better to have an option to keep the Chutney data between runs, even
      when one cannot use --keep-snapshots.
      
      For backwards compatibility, --keep-snapshots implies --keep-chutney.
      5394aba2
  20. 11 May, 2020 3 commits