1. 18 Nov, 2020 1 commit
  2. 17 Nov, 2020 7 commits
  3. 15 Nov, 2020 2 commits
  4. 13 Nov, 2020 1 commit
    • anonym's avatar
      Test suite: wait for GNOME Overview launchers to be ready before interacting... · c42f6c21
      anonym authored
      Test suite: wait for GNOME Overview launchers to be ready before interacting with them (fixes: #18016).
      
      I cannot reproduce this locally, but on Jenkins we see the GNOME
      Overview opening and sometimes showing the launcher bar to the left in
      an incomplete state, with only the top-most icon, Tor Browser, showing
      for ~1 second. When the launcher fully loads it changes height,
      changing the location of the Tor Browser icon. So there is a race
      where we sometimes match the Tor Browser icon and start to click it,
      but before we finish the launcher bar readjusts and the icon is moved
      away from where we click.
      c42f6c21
  5. 12 Nov, 2020 2 commits
  6. 07 Nov, 2020 2 commits
  7. 04 Nov, 2020 1 commit
    • intrigeri's avatar
      Test suite: fix regexp · 33103b2b
      intrigeri authored
      Fix regression introduced by 7b1e2567,
      which breaks all scenarios where we log in in English:
      
        Undefined dynamic step: "I log in to a new session" (Cucumber::UndefinedDynamicStep)
      33103b2b
  8. 02 Nov, 2020 3 commits
    • anonym's avatar
      Test suite: login using the button, not accelerators. · 7b1e2567
      anonym authored
      This allows us to drop the start_accel column in the scenario outline,
      which is nice to not have to maintain.
      7b1e2567
    • anonym's avatar
      Test suite: implement find_any() with real_find(). · d186e198
      anonym authored
      We recently bumped the timeout in find() from 2 to 5 seconds (in !218
      for #17985) which made me notice that it's not very appropriate to
      call find() in find_any() and related functions since that timeout
      makes us block very long on each image before moving on to the next.
      
      I saw an instance where we use find_any() on five images with a 20
      second timeout. This makes it impossible to match the fifth image
      since we'll spend 4*5 = 20 seconds on the first four images and thus
      timeout before we even try the fifth. Ouch!
      d186e198
    • anonym's avatar
      Test suite: calculate supported locales outside of loop. · 777de003
      anonym authored
      Otherwise the debug log is spammed pretty hard during each iteration
      of the loop.
      777de003
  9. 30 Oct, 2020 3 commits
  10. 28 Oct, 2020 1 commit
    • intrigeri's avatar
      Test suite: don't let Screen#find mess with Screen#wait_vanish's timeout argument · d369bb1c
      intrigeri authored
      7fe21236, and later
      d019aa38, by adding an implicit waiting delay in
      Screen#find, made the semantics of the timeout of Screen#wait_vanish buggy: if
      that timeout is too small compared to the duration of that implicit waiting
      delay, then the timeout of the try_for loop in Screen#wait_vanish will expire
      without having actually tried enough times, effectively making the timeout
      passed to wait_vanish moot.
      
      For example, at d019aa38,
      this step:
      
        I do not see "TorBrowserSynapticManual.png" after at most 5 seconds
      
      … often fails, because Screen#wait is called only once, very early,
      and at that time TorBrowserSynapticManual.png is still on the screen.
      That image disappears quickly, but given the 2 timeouts have the same value
      (5 seconds), we don't even try a second time.
      
      So let's bypass Screen#find in Screen#wait_vanish, and instead call
      Screen#wait directly with timeout=0.
      d369bb1c
  11. 27 Oct, 2020 2 commits
  12. 26 Oct, 2020 13 commits
  13. 17 Oct, 2020 1 commit
  14. 15 Oct, 2020 1 commit