1. 18 Oct, 2019 1 commit
    • intrigeri's avatar
      Test suite: make the "SSH is using the default SocksPort" scenario more robust (refs: #17163) · 4353ed57
      intrigeri authored
      This scenario failed 12 times in the last 16 test suite runs on the testing
      branch, so it's starting to be really annoying.
      
      Every time, SSH immediately fails with "nc: connection failed, SOCKSv5 error:
      General SOCKS server failure". I suspect there's a bug in our test suite, that
      makes us try to use Tor before it's ready. Regardless, we have a very similar
      test case in ssh.feature that is pretty robust: it never failed in the 16 test
      suite runs I've analyzed. I see two main potential reasons for this difference:
      
       - In tor_stream_isolation.feature we have the "I monitor the network
         connections of SSH" CPU hog running. This might make it harder for tor to do
         its job.
      
       - In ssh.feature, we use retry_tor so we retry up to
         MAX_NEW_TOR_CIRCUIT_RETRIES (default: 10); while in
         tor_stream_isolation.feature we only run SSH once.
      
      In short, the fragile scenario runs in a context that makes it more likely to
      fail, and it does not retry. So it's not very surprising that it's more fragile.
      
      Therefore, let's simply reuse the existing, robust implementation we have for
      a test connecting to a SSH server on the Internet. In passing, we get rid
      of one picture, which is always welcome.
      4353ed57
  2. 01 Sep, 2019 1 commit
  3. 26 Aug, 2019 1 commit
  4. 11 Jul, 2019 2 commits
  5. 06 May, 2019 2 commits
    • intrigeri's avatar
      Test suite: make terminology more consistent. · 89c9074b
      intrigeri authored
      The "Torified session" terminology is not wide-spread and its meaning
      is not super obvious. Let's instead use "Tor streams", which matches
      Tor's own terminology and the name of this very Cucumber feature.
      89c9074b
    • intrigeri's avatar
      Test suite: make tails-security-check's SOCKS port test work when there's a... · c36f0684
      intrigeri authored
      Test suite: make tails-security-check's SOCKS port test work when there's a live security advisory (refs: #16701)
      
      With a live security advisory, an instance of tails-security-check is already
      running, which breaks "I re-run tails-security-check" (timeout waiting for the
      process to exit). Let's instead re-run it via its systemd service, so that:
      
      1. any already running tails-security-check is killed, which fixes this bug;
      
      2. we test tails-security-check in an environment closer to how it's run in
         a real Tails: as we can see on #16603, running this kind of scripts via
         systemd or without it can yield subtly different behavior.
      
      But systemctl returns as soon as the process is started, while our
      previous implementation waited for tails-security-check to exit.
      So we need to wait a little bit before analysing the network trace.
      c36f0684
  6. 08 Apr, 2019 1 commit
    • intrigeri's avatar
      Test suite: remove tests that exercise Gobby or otherwise rely on it (refs: #15291) · 13cc510f
      intrigeri authored
      We lose the "Explicitly torify-wrapped applications are using the default
      SocksPort" and "Explicitly torsocks-wrapped applications are using the default
      SocksPort" scenarios along the way. We could of course rewrite them to test
      something else than Gobby but I see very little value in it: in practice,
      they merely test that the default configuration of torsocks and torify
      is what it has been since these pieces of software were created.
      13cc510f
  7. 07 Jun, 2017 1 commit
    • anonym's avatar
      Test suite: rename step. · be98070a
      anonym authored
      The current name is completely wrong -- the menu navigation was
      completely broken due to #11718 and it was thought we would be able to
      fix it and revert the GNOME Activities workaround, and just skip the
      renaming since the workaround was temporary. Well, it seems that the
      menu handling still is not reliable, even with #11718 fixed, so let's
      stick with what has worked pretty good during the feature/stretch
      development.
      
      Refs: #11718
      be98070a
  8. 16 Nov, 2016 1 commit
  9. 22 Jul, 2016 1 commit
  10. 20 Feb, 2016 1 commit
  11. 07 Dec, 2015 1 commit
  12. 15 Oct, 2015 1 commit
  13. 06 Oct, 2015 1 commit
    • anonym's avatar
      Improve names of generated snapshot restoring steps. · 83bde0f9
      anonym authored
      Essentially I did:
      
          sed -i 's/Tails has booted/I have started Tails/' -- \
              features/*.feature features/step_definitions/snapshots.rb
      
      (although there was a false positive that I had to restore)
      83bde0f9
  14. 15 May, 2015 1 commit
  15. 18 Feb, 2015 4 commits
  16. 09 Feb, 2015 1 commit
  17. 04 Feb, 2015 2 commits
    • Tails developers's avatar
      Improve step name. · 1025c5d7
      Tails developers authored
      By saying "traffic" we may give the impression that we're monitoring
      on the packet level, but `netstat` only lists socket-level
      information, which is more about "connections".
      1025c5d7
    • Tails developers's avatar
      Grammar fix. · 75e2fcfd
      Tails developers authored
      75e2fcfd
  18. 03 Feb, 2015 15 commits